[codex] Clarify runtime route roles#174
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 71c19df360
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| fi | ||
| if [ "${raw_path}" = "/" ] && [ "${{ inputs.allow_live_execution }}" != "true" ]; then | ||
| echo "Calling / can trigger the live execution entrypoint. Re-run with allow_live_execution=true if this is intentional." >&2 | ||
| if { [ "${raw_path}" = "/" ] || [ "${raw_path}" = "/run" ]; } && [ "${{ inputs.allow_live_execution }}" != "true" ]; then |
There was a problem hiding this comment.
When this workflow is used against a non-internal service, a path like /run?reason=manual will not satisfy this exact /run comparison, so it falls through to the direct curl invocation while Flask still routes it to the new /run live handler. That bypasses allow_live_execution=false and can trigger live trading; parse or normalize the path component before applying the live-entrypoint guard.
Useful? React with 👍 / 👎.
1 participant
Summary
Validation